[GitHub] [parquet-format] pitrou commented on a change in pull request #168: PARQUET-1996: [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

[GitBox]

pitrou commented on a change in pull request #168:
URL: https://github.com/apache/parquet-format/pull/168#discussion_r590644296



##########
File path: src/main/thrift/parquet.thrift
##########
@@ -481,9 +481,10 @@ enum CompressionCodec {
   SNAPPY = 1;
   GZIP = 2;
   LZO = 3;
-  BROTLI = 4; // Added in 2.4
-  LZ4 = 5;    // Added in 2.4
-  ZSTD = 6;   // Added in 2.4
+  BROTLI = 4;  // Added in 2.4
+  LZ4 = 5;     // DEPRECATED (Added in 2.4)
+  ZSTD = 6;    // Added in 2.4
+  LZ4_RAW = 7; // Added in 2.9

Review comment:
       This is proposing the LZ4 _block_ format, not the LZ4 _frame_ format 
which the dependent blocks error seems to be stemming from.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org