[
https://issues.apache.org/jira/browse/PARQUET-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314579#comment-17314579
]
ASF GitHub Bot commented on PARQUET-2013:
-----------------------------------------
wesm commented on a change in pull request #169:
URL: https://github.com/apache/parquet-format/pull/169#discussion_r606836868
##########
File path: src/main/thrift/parquet.thrift
##########
@@ -316,7 +317,7 @@ struct BsonType {
* LogicalType annotations to replace ConvertedType.
*
* To maintain compatibility, implementations using LogicalType for a
- * SchemaElement must also set the corresponding ConvertedType from the
+ * SchemaElement should also set the corresponding ConvertedType from the
Review comment:
It's a change with forward compatibility implications, so either we
revert or we discuss/vote, but we can't leave it like this. Impala for example
only started to get support for LogicalType in 2019 (and this is only one of
the mainstream independent implementations), so we'd be making a bet about how
quickly updates are rolling out to all of the corners of the world
https://github.com/apache/impala/commit/0906e0817ce2301d7e20f355b334861f0232f16f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Format] Mention that converted types are deprecated
> ----------------------------------------------------
>
> Key: PARQUET-2013
> URL: https://issues.apache.org/jira/browse/PARQUET-2013
> Project: Parquet
> Issue Type: Task
> Components: parquet-format
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Major
> Fix For: format-2.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
