Miksu82 commented on pull request #895:
URL: https://github.com/apache/parquet-mr/pull/895#issuecomment-823282453
Unfortunately I cannot find a way to only assert that properties have been
set. It probably could be done with extensive refactoring but I don't see the
point to do that in this test. Also other property setters in the builder are
not unit tested so I guess I could just remove these tests completely.
However I did notice that I can assert the number of flushes by counting the
number of blocks in the Parquet file footer. Asserting that way would make the
test easier to understand.
Let me know what you prefer. Remove the tests or fix the assertations? I'll
continue after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
