sunchao commented on pull request #910: URL: https://github.com/apache/parquet-mr/pull/910#issuecomment-848039158
Thanks @gszadovszky and @shangxinli for taking a look. > It is another question if all the encoders used for writing data pages for binary values are prepared for similar situations. After fallback from dictionary encoding, I think it will fail later [during writing data page](https://github.com/apache/parquet-mr/blob/apache-parquet-1.12.0/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java#L163). I think this is still better than generating corrupted page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
