[
https://issues.apache.org/jira/browse/PARQUET-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367174#comment-17367174
]
ASF GitHub Bot commented on PARQUET-2059:
-----------------------------------------
gszadovszky opened a new pull request #915:
URL: https://github.com/apache/parquet-mr/pull/915
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Tests require to much memory
> ----------------------------
>
> Key: PARQUET-2059
> URL: https://issues.apache.org/jira/browse/PARQUET-2059
> Project: Parquet
> Issue Type: Test
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
>
> For testing the solution of PARQUET-1633 we require ~3GB memory that is not
> always available. To solve this issue we temporarily disabled the implemented
> unit test.
> We need to ensure somehow that [this
> test|https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestLargeColumnChunk.java]
> (and maybe some other similar ones) are executed regularly. Some options we
> might have:
> * Execute this test separately with a maven profile. I am not sure if the CI
> allows allocating such large memory but with Xmx options we might give a try
> and create a separate check for this test only.
> * Similar to the previous with the profile but not executing in the CI ever.
> Instead, we add some comments to the release doc so this test will be
> executed at least once per release.
> * Configuring the CI profile to skip this test but have it in the normal
> scenario meaning the devs will execute it locally. There are a couple of cons
> though. There is no guarantee that devs executes all the tests including this
> one. It also can cause issues if the dev doesn't have enough memory and don't
> know that the test failure is not related to the current change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
