[ 
https://issues.apache.org/jira/browse/PARQUET-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394454#comment-17394454
 ] 

JiangYang commented on PARQUET-2073:
------------------------------------

this line is to calculate the rowsToFillPage number.

rows(one row more than one bytes) should be always smaller than usedMem, so the 
rowsToFillPage always be zero, in current code.

 

I think you are right we should use 
(long) ((double) rows / usedMem * remainingMem )
for more accurate numbers.

 

Could I create a PR for fix this ?  I want to be involved in the community, 
especially big data storage. 

> Is there something wrong calculate usedMem in ColumnWriteStoreBase.java
> -----------------------------------------------------------------------
>
>                 Key: PARQUET-2073
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2073
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-mr
>    Affects Versions: 1.12.0
>            Reporter: JiangYang
>            Priority: Critical
>         Attachments: image-2021-08-05-14-37-51-299.png
>
>
> !image-2021-08-05-14-37-51-299.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to