ggershinsky commented on a change in pull request #925:
URL: https://github.com/apache/parquet-mr/pull/925#discussion_r699207678
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##########
@@ -1226,12 +1226,25 @@ public ParquetMetadata readParquetMetadata(InputStream
from) throws IOException
static FileMetaData filterFileMetaDataByMidpoint(FileMetaData metaData,
RangeMetadataFilter filter) {
List<RowGroup> rowGroups = metaData.getRow_groups();
List<RowGroup> newRowGroups = new ArrayList<RowGroup>();
+ long preStartIndex = 0;
+ long preCompressedSize = 0;
for (RowGroup rowGroup : rowGroups) {
long totalSize = 0;
long startIndex;
-
if (rowGroup.isSetFile_offset()) {
- startIndex = rowGroup.getFile_offset();
+ assert rowGroup.isSetTotal_compressed_size();
+
+ if (preStartIndex == 0) {
+ //the first block always holds the truth
+ startIndex = rowGroup.getFile_offset();
+ } else {
+ //calculate offset for other blocks
Review comment:
Could you expand the comment a bit, to briefly explain the problem?
(maybe with mentioning the jira number). To help ensure future changes don't
revert this to the more intuitive getFile_offset().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
