ggershinsky edited a comment on pull request #925: URL: https://github.com/apache/parquet-mr/pull/925#issuecomment-916104298
Sure, looks good. The first row group always starts at offset 4. @loudongfeng Maybe the hardcoded `4` should be replaced with eg `ParquetFileWriter.MAGIC.length`? Or even better, a new constant added at `ParquetFileWriter`, something like 'FIRST_ROW_OFFSET = MAGIC.length` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
