Thanks a lot for working on this, Xinli. Do not forget that you also have a vote :)
I have some issues with the content of the release. I would not include the change PARQUET-2043. It is not a bugfix and contains a lot of changes around dependencies. I feel it a bit risky to include it in a patch release. I also don't get why the change 261e320329d719ef3c7f05ff2c3feb788d6ffd4f <https://github.com/apache/parquet-mr/commit/261e320329d719ef3c7f05ff2c3feb788d6ffd4f> was necessary. We should not remove modules in a patch release. Because of these issues I my vote is -1 (binding) Please, also take care about the release <https://issues.apache.org/jira/projects/PARQUET/versions/12350120> in the jira. There are only 2 issues registered for 1.12.1. Cheers, Gabor On Mon, Sep 13, 2021 at 9:42 AM Gidon Gershinsky <[email protected]> wrote: > +1 (non-binding) > > - checked the sum > - ran build and test, everything was ok > - ran additional framework tests with the built jars, passed > > Cheers, Gidon > > > On Sun, Sep 12, 2021 at 12:05 AM Xinli shang <[email protected]> > wrote: > > > Hi everyone, > > > > > > I propose the following RC to be released as the official Apache Parquet > > <VERSION> release. > > > > > > The commit id is d1dccf6e680d86e94ce97005f5ac51848ba6d794 > > > > * This corresponds to the tag: apache-parquet-1.12.1-rc0 > > > > * https://github.com/apache/parquet-mr/tree/ > > d1dccf6e680d86e94ce97005f5ac51848ba6d794 > > > > > > The release tarball, signature, and checksums are here: > > > > * > > > https://dist.apache.org/repos/dist/dev/parquet/apache-parquet-1.12.1-rc0/ > > > > > > You can find the KEYS file here: > > > > * *https://dist.apache.org/repos/dist/release/parquet/KEYS > > <https://dist.apache.org/repos/dist/release/parquet/KEYS>* > > > > > > Binary artifacts are staged in Nexus here: > > > > * > https://repository.apache.org/content/groups/staging/org/apache/parquet/ > > > > > > This release includes important changes listed > > https://github.com/apache/parquet-mr/blob/parquet-1.12.x/CHANGES.md > > > > > > Please download, verify, and test. > > > > > > Please vote in the next 72 hours. > > > > > > [ ] +1 Release this as Apache Parquet 1.12.1 > > > > [ ] +0 > > > > [ ] -1 Do not release this because... > > > > -- > > Xinli Shang > > >
