[
https://issues.apache.org/jira/browse/PARQUET-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417347#comment-17417347
]
ASF GitHub Bot commented on PARQUET-2081:
-----------------------------------------
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r711755012
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java
##########
@@ -599,6 +599,31 @@ private void innerWriteDataPage(
Encoding rlEncoding,
Encoding dlEncoding,
Encoding valuesEncoding) throws IOException {
+ writeDataPage(valueCount, uncompressedPageSize, bytes, statistics,
rlEncoding, dlEncoding, valuesEncoding, null, null);
+ }
+
+ /**
+ * writes a single page
+ * @param valueCount count of values
+ * @param uncompressedPageSize the size of the data once uncompressed
+ * @param bytes the compressed data for the page without header
+ * @param statistics statistics for the page
+ * @param rlEncoding encoding of the repetition level
+ * @param dlEncoding encoding of the definition level
+ * @param valuesEncoding encoding of values
+ * @param blockEncryptor encryptor for block data
+ * @param AAD AAD
Review comment:
I just followed the existing name, but this is correct feedback. So I
changed not only this one but also several other places to rename AAD to
pageHeadAAD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Encryption translation tool - Parquet-hadoop
> --------------------------------------------
>
> Key: PARQUET-2081
> URL: https://issues.apache.org/jira/browse/PARQUET-2081
> Project: Parquet
> Issue Type: Task
> Components: parquet-mr
> Reporter: Xinli Shang
> Priority: Major
> Fix For: 1.13.0
>
>
> This is the implement the core part of the Encryption translation tool in
> parquet-hadoop. After this, we will have another Jira/PR for parquet-cli to
> integrate with key tools for encryption properties..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
