gszadovszky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r712039072
##########
File path: pom.xml
##########
@@ -522,6 +522,7 @@
change to fix a integer overflow issue.
TODO: remove this after Parquet 1.13 release -->
<exclude>org.apache.parquet.column.values.dictionary.DictionaryValuesWriter#dictionaryByteSize</exclude>
+ <exclude>org.apache.parquet.hadoop.util</exclude>
Review comment:
Maybe I was misleading. For me it doesn't matter if we have a package or
classes listed here. My problem is that we are breaking backward compatibility
from the API point of view. If we think it is OK to break the compatibility of
this package then I am fine having it here but with a separate comment. (For
`DictionaryValuesWriter` we did not have a choice to not to break the API
that's why the TODO is there.)
So, if the `util` package is not for public use than we shall add `@Private`
to all of its classes and maybe also add a `package-info.java` stating that
this is not for public use and add similar comments here as well. Otherwise, we
should maintain backward compatibility for these classes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
