ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717301743
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##########
@@ -503,7 +503,7 @@ private void addRowGroup(ParquetMetadata parquetMetadata,
List<RowGroup> rowGrou
ColumnPath path = columnMetaData.getPath();
if (null != fileEncryptor) {
columnOrdinal++;
- columnSetup = fileEncryptor.getColumnSetup(path, false, columnOrdinal);
+ columnSetup = fileEncryptor.getColumnSetup(path, true, columnOrdinal);
Review comment:
yep, it's ok to call getColumnSetup for every column. In any case, the
true/false here is not an indication of whether column is encrypted or not.
This boolean is simply a flag whether the column setup should have already been
created at this point, a simple flow check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
