gszadovszky commented on a change in pull request #935:
URL: https://github.com/apache/parquet-mr/pull/935#discussion_r732870171
##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java
##########
@@ -37,6 +37,12 @@
protected static final int GCM_TAG_LENGTH_BITS = 8 * GCM_TAG_LENGTH;
protected static final int CHUNK_LENGTH = 4 * 1024;
protected static final int SIZE_LENGTH = ModuleCipherFactory.SIZE_LENGTH;
+ // NIST SP 800-38D section 8.3 specifies limit on AES GCM encryption
operations with same key and random IV/nonce
+ protected static final long GCM_RANDOM_IV_SAME_KEY_MAX_OPS = 2^32;
Review comment:
`2 ^ 32` is not 2 on the power of 32 in java but `2 XOR 32` which is 34.
I would suggest using `1 << 32` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
