gszadovszky commented on a change in pull request #940:
URL: https://github.com/apache/parquet-mr/pull/940#discussion_r763814302
##########
File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
##########
@@ -542,6 +606,10 @@ public static Binary fromCharSequence(CharSequence value) {
return new FromCharSequenceBinary(value);
}
+ public static int compareToLexicographic(Binary one, Binary other) {
Review comment:
`compareTo` is usually used when `this` is to be compared to the
argument. In case of a method comparing the two arguments to each other
`compare` is preferred.
I think, either `lexicographicCompare` or `compareLexicographically` would
be better than the current one.
The naming of the package private methods that really compares `this` to the
argument is less important to me but still, something like
`lexicographicCompareTo` or `compareToLexicographically` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
