alexeykudinkin opened a new pull request #940: URL: https://github.com/apache/parquet-mr/pull/940
This refactors `BinaryComparator` to essentially avoid any allocations in the routine of comparing 2 `Binary` objects. More details could be found in [PARQUET-2106](https://issues.apache.org/jira/browse/PARQUET-2106) ### Jira - [ ] My PR addresses [PARQUET-2106](https://issues.apache.org/jira/browse/PARQUET-2106) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR" ### Tests - Does not need testing, since it's a simple refactoring that changes flows that are already covered ### Commits - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
