shangxinli commented on a change in pull request #945:
URL: https://github.com/apache/parquet-mr/pull/945#discussion_r814791362
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##########
@@ -1476,6 +1509,13 @@ public ParquetMetadata fromParquetMetadata(FileMetaData
parquetMetadata) throws
public ParquetMetadata fromParquetMetadata(FileMetaData parquetMetadata,
InternalFileDecryptor fileDecryptor, boolean encryptedFooter) throws
IOException {
+ return fromParquetMetadata(parquetMetadata, fileDecryptor,
encryptedFooter, generateRowGroupOffsets(parquetMetadata));
Review comment:
As you mentioned above, if parquetMetadata is a filtered one, then
generateRowGroupOffsets() won't return accurate offsets, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
