rdblue commented on code in PR #953:
URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857175853
##########
parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java:
##########
@@ -88,6 +132,15 @@ public long skip(long n) {
return bytesToSkip;
}
+ @Override
+ public void skipFully(long n) throws IOException {
+ try {
+ buffer.position(buffer.position() + (int)n);
Review Comment:
Looks like this is just trying to avoid the checks that are being done in
`skip`. I don't think that's a good idea. This should delegate to skip instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
