theosib-amazon commented on code in PR #953:
URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857889202
##########
parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java:
##########
@@ -88,6 +132,15 @@ public long skip(long n) {
return bytesToSkip;
}
+ @Override
+ public void skipFully(long n) throws IOException {
+ try {
+ buffer.position(buffer.position() + (int)n);
Review Comment:
I did this specifically because it's performance-critical. I did a bunch of
profiling, and skips are among the operations that have to have minimal
overhead. Delegating to skip() would introduce a bunch of checks that the JIT
isn't going to be smart enough to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
