ASF GitHub Bot commented on PARQUET-2150:

steveloughran opened a new pull request, #970:
URL: https://github.com/apache/parquet-mr/pull/970

   Force use of x86 protocol executable in builds onl macOS systems,
   including those with ARM64 architectures, for which native binaries
   do not exist.
   ### Jira
   - [X] My PR addresses the following [Parquet 
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references 
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   It can only be validated on an M1 mac. the normal CI test runs will verify 
the changes do not cause regressions elsewhere.
   Note: this patch was based on hadoop's HADOOP-17939 patch 
https://github.com/apache/hadoop/pull/3486 -this was needed to fix the hadoop 
   ### Commits
   - [X] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   ### Documentation
   - [X] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does

> parquet-protobuf to compile on mac M1
> -------------------------------------
>                 Key: PARQUET-2150
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2150
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-protobuf
>    Affects Versions: 1.13.0
>            Reporter: Steve Loughran
>            Priority: Major
> parquet-protobuf module fails to compile on Mac M1 because the maven protoc 
> plugin cannot find the native osx-aarch_64:3.16.1  binary.
> the build needs to be tweaked to pick up the x86 binaries

This message was sent by Atlassian Jira

Reply via email to