steveloughran commented on code in PR #951: URL: https://github.com/apache/parquet-mr/pull/951#discussion_r890391185
########## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ########## @@ -66,6 +67,19 @@ public static SeekableInputStream wrap(FSDataInputStream stream) { } } + private static boolean isWrappedStreamByteBufferReadable(FSDataInputStream stream) { + InputStream wrapped = stream.getWrappedStream(); + if (wrapped == stream) { + throw new ParquetDecodingException("Illegal FSDataInputStream as wrapped itself"); Review Comment: this can't happen. the inner stream is set in the constructor, so cannot take the not-yet-constructed class as an argument...no need to worry about recursion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org