shangxinli commented on code in PR #960:
URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950907839
##########
parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java:
##########
@@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) {
}
@Override
- public int read(byte[] bytes) {
- return read(bytes, 0, bytes.length);
+ public void readFully(byte[] bytes, int off, int len) throws IOException {
Review Comment:
The difference between this method and read() is mainly to precheck if there
is enough remaining length. I believe this can be done by wrapping up the
read() method and adding the prechecks. Duplicating the code makes it harder to
maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
