shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950908609
########## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ########## @@ -88,6 +136,21 @@ public long skip(long n) { return bytesToSkip; } + @Override + public void skipFully(long n) throws IOException { + if (n < 0 || n > Integer.MAX_VALUE) { + throw new IllegalArgumentException(); + } + + try { + buffer.position(buffer.position() + (int)n); + } catch (IllegalArgumentException e) { Review Comment: the try/catch is also more expensive than checking. I agree with Chao to have the check instead of try/catch. ########## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ########## @@ -88,6 +136,21 @@ public long skip(long n) { return bytesToSkip; } + @Override + public void skipFully(long n) throws IOException { + if (n < 0 || n > Integer.MAX_VALUE) { + throw new IllegalArgumentException(); + } + + try { + buffer.position(buffer.position() + (int)n); + } catch (IllegalArgumentException e) { Review Comment: The try/catch is also more expensive than checking. I agree with Chao to have the check instead of try/catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org