[GitHub] [parquet-format] pitrou commented on a diff in pull request #184: PARQUET-758: Add Float16/Half-float logical type

[GitBox]

pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957065065


##########
src/main/thrift/parquet.thrift:
##########
@@ -889,6 +891,7 @@ union ColumnOrder {
    *   INT32 - signed comparison
    *   INT64 - signed comparison
    *   INT96 (only used for legacy timestamps) - undefined
+   *   FLOAT16 - signed comparison of the represented value (*)

Review Comment:
   Same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org