[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597061#comment-17597061
]
ASF GitHub Bot commented on PARQUET-758:
----------------------------------------
pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957064862
##########
src/main/thrift/parquet.thrift:
##########
@@ -416,6 +417,7 @@ enum Encoding {
* BOOLEAN - 1 bit per value. 0 is false; 1 is true.
* INT32 - 4 bytes per value. Stored as little-endian.
* INT64 - 8 bytes per value. Stored as little-endian.
+ * FLOAT16 - 2 bytes per value. IEEE. Stored as little-endian.
Review Comment:
You shouldn't mention logical types in this comment, only physical types.
> HALF precision FLOAT Logical type
> ---------------------------------
>
> Key: PARQUET-758
> URL: https://issues.apache.org/jira/browse/PARQUET-758
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-format
> Reporter: Julien Le Dem
> Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
