ggershinsky commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1021580279
########## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java: ########## @@ -133,11 +135,33 @@ public DataPage readPage() { public DataPage visit(DataPageV1 dataPageV1) { try { BytesInput bytes = dataPageV1.getBytes(); - if (null != blockDecryptor) { - bytes = BytesInput.from(blockDecryptor.decrypt(bytes.toByteArray(), dataPageAAD)); + ByteBuffer byteBuffer = bytes.toByteBuffer(); + BytesInput decompressed; + + if (byteBuffer.isDirect() && options.useOffHeapDecryptBuffer()) { + if (blockDecryptor != null) { + byteBuffer = blockDecryptor.decrypt(byteBuffer, dataPageAAD); + } + long compressedSize = byteBuffer.limit(); + + ByteBuffer decompressedBuffer = + ByteBuffer.allocateDirect(dataPageV1.getUncompressedSize()); + decompressor.decompress(byteBuffer, (int) compressedSize, decompressedBuffer, Review Comment: Looks like this PR goes beyond decryption, and adds direct buffers to decompression too. Please update the title (or split the PR in two). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org