steveloughran commented on PR #1010: URL: https://github.com/apache/parquet-mr/pull/1010#issuecomment-1317388449
> For instance Iceberg has this [S3InputFile](https://github.com/apache/iceberg/blob/master/aws/src/main/java/org/apache/iceberg/aws/s3/S3InputFile.java) which knows nothing about file status or read policy. the builder api we use has opt(key, val) being something implementations can ignore, must(key, val) says "you must recognise the key and 'val' must be something you understand". so opening a file with a length and read policy would be ignored by iceberg automatically if in opt() ``` fc.openFile(p) .opt("fs.option.openfile.read.policy", "random") .opt("fs.option.openfile.length", Long.toString(status.getLen())) ``` put them in must() and the implementation must recognise the keys, even if it *chooses* to not actually do anything with the length/policy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
