wgtmac commented on PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#issuecomment-1371885483
> If you can add more unit tests, particularly the combinations of prune, mask, trans-compression etc, it would be better. I have added some test cases in the `ParquetRewriterTest` to mix config of prune, nullify and trans-compression. There are two outstanding issues as below: - Masking and encrypting same column is not supported yet. - Fix `createdBy` of rewritten file to keep both original info and new rewriter info. I am inclined to fix them in separate JIRAs because this patch is simply a refactoring patch to unify different rewriters without changing any behavior, and it is large enough. @ggershinsky @shangxinli Please review again when you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
