[ https://issues.apache.org/jira/browse/PARQUET-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677057#comment-17677057 ]
ASF GitHub Bot commented on PARQUET-2226: ----------------------------------------- yabola commented on code in PR #1020: URL: https://github.com/apache/parquet-mr/pull/1020#discussion_r1070636680 ########## parquet-column/src/main/java/org/apache/parquet/column/values/bloomfilter/BlockSplitBloomFilter.java: ########## @@ -398,18 +398,21 @@ public long hash(Binary value) { @Override public void merge(BloomFilter otherBloomFilter) throws IOException { - Preconditions.checkArgument((otherBloomFilter.getAlgorithm() == getAlgorithm()), - "BloomFilter algorithm should be same"); - Preconditions.checkArgument((otherBloomFilter.getHashStrategy() == getHashStrategy()), - "BloomFilter hashStrategy should be same"); - Preconditions.checkArgument((otherBloomFilter.getBitsetSize() == getBitsetSize()), - "BloomFilter bitset size should be same"); + Preconditions.checkArgument(otherBloomFilter != null, "Cannot merge a null BloomFilter"); + Preconditions.checkArgument((getAlgorithm() == otherBloomFilter.getAlgorithm()), Review Comment: Thanks, done > Support merge Bloom Filter > -------------------------- > > Key: PARQUET-2226 > URL: https://issues.apache.org/jira/browse/PARQUET-2226 > Project: Parquet > Issue Type: Improvement > Reporter: Mars > Priority: Major > > We need to collect Parquet's bloom filter of multiple files, and then > synthesize a more comprehensive bloom filter for common use. > Guava supports similar api operations > https://guava.dev/releases/31.0.1-jre/api/docs/src-html/com/google/common/hash/BloomFilter.html#line.252 -- This message was sent by Atlassian Jira (v8.20.10#820010)