[ 
https://issues.apache.org/jira/browse/PARQUET-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706122#comment-17706122
 ] 

ASF GitHub Bot commented on PARQUET-2261:
-----------------------------------------

yqiu2 commented on code in PR #197:
URL: https://github.com/apache/parquet-format/pull/197#discussion_r1151068954


##########
src/main/thrift/parquet.thrift:
##########
@@ -190,6 +190,45 @@ enum FieldRepetitionType {
   /** The field is repeated and can contain 0 or more values */
   REPEATED = 2;
 }
+/**
+ * A structure for capturing metadata for estimating the unencoded, 
uncompressed size
+ * of data.
+ *
+ * Writers should populate all fields in this struct except for the exceptions 
listed per field.
+ */ 
+struct SizeEstimationStatistics {
+   /** 
+    * The number of logical physical bytes stored for BYTE_ARRAY data values. 
Logical bytes refers to the number
+    * of bytes needed if no special encoding is used. This is exclusive of the 
bytes needed
+    * to store the length of each byte array. In other words, this field is 
equivelant to the the (size of 
+    * PLAIN-ENCODING the byte array values) - (4 bytes * number of values 
written). To determine logical sizes 

Review Comment:
   4 bytes * number of values written
   is that the logical size of the data? Is this assuming that each value takes 
4 bytes of space?





> [Format] Add statistics that reflect decoded size to metadata
> -------------------------------------------------------------
>
>                 Key: PARQUET-2261
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2261
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-format
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to