I think we are about the release under the wrong number then. We should do minor releases from master and then cut branch for that minor release to support patch (bugfix) releases. I've just realized we have new features and improvements for this (and the previous) release. Features and improvements should be released in minor releases. (We want to be backward compatible so wouldn't talk about major releases.)
I think we should fail this release and restart a new one (probably with the same content) from the master branch with the version number 1.13.0. WDYT? We shall also not forget that if we want to do a patch/bugfix release for 1.12.x, we'll need to include the content of 1.12.3 as well. Maybe by backporting all the changes to the branch 1.12.x to make it consistent? On 2023/03/31 14:53:47 Gang Wu wrote: > Thanks Gabor! > > I cut the branch from master for v1.12.4 release for the following reasons: > > - parquet-1.12.x branch has no new commit after v1.12.2 release (namely > the v1.12.2 tag) > - parquet-1.12.3 branch was cut from master branch and has no new commit > after v1.12.3 release (namely the v1.12.3 tag) > - All new commits after v1.12.3 release are in the master branch. > - I did check that commits in the v1.12.2 are included in the v1.12.3 > release (as well as the master branch) > > So I think we are good. > > Best, > Gang > > On Fri, Mar 31, 2023 at 9:49 PM Gábor Szádovszky <[email protected]> wrote: > > > Sorry for the late response. > > > > Verified checksum and signature, diffed tarball and repo content, > > build/unit tests pass. > > > > I'm a bit confused of our current branching, though. We have one for > > parquet-1.12.x. Every 1.12 release should be built/tagged there. Meanwhile > > we have a separate branch for 1.12.3 and yet another one for the current > > 1.12.4. Both are depending on 1.12.0 tag. How do we ensure all the previous > > 1.12.x fixes are included? @Gang, could you please double check if this > > release candidate contains everything from the prevous 1.12.x releases? > > Until then I'm giving a -0. > > > > Cheers, > > Gabor > > > > On 2023/03/30 20:11:47 Xinli shang wrote: > > > Yeah, let's expand the 72 hours time limit. I am asking other PMCs to > > vote > > > too now. > > > > > > On Wed, Mar 29, 2023 at 6:49 PM Gang Wu <[email protected]> wrote: > > > > > > > Thank you all! > > > > > > > > I have checked the Apache Voting Processing [1] and Release Policy [2]. > > > > Both of them say that a vote should be valid for at least 72 hours. > > > > > > > > As we need one more binding vote from PMC members to pass the vote, I > > think > > > > we may need to extend the vote to receive enough replies. > > > > > > > > Any suggestions? > > > > > > > > [1] > > > > > > > > > > https://www.apache.org/foundation/voting.html#expressing-votes-1-0-1-and-fractions > > > > [2] https://www.apache.org/legal/release-policy.html#release-approval > > > > > > > > Best, > > > > Gang > > > > > > > > On Thu, Mar 30, 2023 at 12:00 AM Dongjoon Hyun <[email protected]> > > > > wrote: > > > > > > > > > Thank you all. > > > > > > > > > > Hi, Gang. Could you conclude this RC0 vote since it seems to pass 72 > > > > hours? > > > > > > > > > > Thanks, > > > > > Dongjoon. > > > > > > > > > > On 2023/03/29 05:54:45 Gang Wu wrote: > > > > > > Yes, I have updated my GPG key but have not sent it to > > > > > http://pgp.mit.edu/. > > > > > > > > > > > > You may find my key from keys.openpgp.org > > > > > > > > > > > > Best, > > > > > > Gang > > > > > > > > > > > > On Wed, Mar 29, 2023 at 1:51 PM L. C. Hsieh <[email protected]> > > wrote: > > > > > > > > > > > > > Hi Gang, > > > > > > > > > > > > > > I tried to search your public key on http://pgp.mit.edu/. > > > > > > > It shows a different public key: > > > > > > > > > > > > > > pub 4096R/26D4D78E 2018-04-11 Gang Wu <[email protected]> > > > > > > > > > > > > > > Looks like it is your older public key? Wondering why your new > > public > > > > > key > > > > > > > is not updated on key server. > > > > > > > > > > > > > > On 2023/03/29 02:59:47 Gang Wu wrote: > > > > > > > > Hi L.C. > > > > > > > > > > > > > > > > Could you please elaborate the issue with public key? How can I > > > > check > > > > > > > that > > > > > > > > by myself? > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Gang > > > > > > > > > > > > > > > > On Wed, Mar 29, 2023 at 7:48 AM L. C. Hsieh <[email protected] > > > > > > > > wrote: > > > > > > > > > > > > > > > > > +1 (non-binding) Verified checksum and ran the tests locally. > > > > > > > > > > > > > > > > > > Thanks Gang. > > > > > > > > > > > > > > > > > > One question is that the public key I saw on key server ( > > > > > > > pgpkeys.mit.edu) > > > > > > > > > is different to the one in > > > > > https://downloads.apache.org/parquet/KEYS. > > > > > > > > > > > > > > > > > > On 2023/03/28 17:01:30 Chao Sun wrote: > > > > > > > > > > +1 (non-binding). Verified checksum & signature, and ran > > all > > > > the > > > > > > > tests > > > > > > > > > locally. > > > > > > > > > > > > > > > > > > > > Thanks Gang! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 28, 2023 at 9:37 AM Gidon Gershinsky < > > > > > [email protected]> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > Verified signature and ran the tests. Thanks Gang and all > > > > > > > contributors! > > > > > > > > > > > > > > > > > > > > > > Cheers, Gidon > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 28, 2023 at 5:19 PM Xinli shang > > > > > > > <[email protected]> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > > > Verified signature and ran internal tests. Thanks > > Gang for > > > > > > > leading > > > > > > > > > this > > > > > > > > > > > > effort! > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 27, 2023 at 9:38 AM Dongjoon Hyun < > > > > > > > [email protected]> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > > > > > Thank you, Gang and Yuming. > > > > > > > > > > > > > > > > > > > > > > > > > > Dongjoon. > > > > > > > > > > > > > > > > > > > > > > > > > > On 2023/03/27 05:44:14 "Wang, Yuming" wrote: > > > > > > > > > > > > > > +1. Tested this release through Spark UT: > > > > > > > > > > > > > https://github.com/apache/spark/pull/40555. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Gang Wu <[email protected]> > > > > > > > > > > > > > > Date: Sunday, March 26, 2023 at 22:42 > > > > > > > > > > > > > > To: [email protected] <[email protected] > > > > > > > > > > > > > > > > > Subject: [VOTE] Release Apache Parquet 1.12.4 RC0 > > > > > > > > > > > > > > External Email > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > > > > > > > > > > > I propose the following RC to be released as the > > > > official > > > > > > > Apache > > > > > > > > > > > > Parquet > > > > > > > > > > > > > > 1.12.4 release. > > > > > > > > > > > > > > > > > > > > > > > > > > > > The commit id is > > > > 22069e58494e7cb5d50e664c7ffa1cf1468404f8 > > > > > > > > > > > > > > * This corresponds to the tag: > > > > apache-parquet-1.12.4-rc0 > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fparquet-mr%2Ftree%2F22069e58494e7cb5d50e664c7ffa1cf1468404f8&data=05%7C01%7Cyumwang%40ebay.com%7Cc5216cd229664f939b6508db2e0855ed%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C638154385567464296%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Bny4R%2BgGQwIc3yMxsHfPh87YYTPhJ580UUoGV30WUQU%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > The release tarball, signature, and checksums are > > here: > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fparquet%2Fapache-parquet-1.12.4-rc0&data=05%7C01%7Cyumwang%40ebay.com%7Cc5216cd229664f939b6508db2e0855ed%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C638154385567464296%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qW7uIIvyamqkT7FbkBWvwKD1VnfeRWnKLUBpcVHXvck%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > You can find the KEYS file here: > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownloads.apache.org%2Fparquet%2FKEYS&data=05%7C01%7Cyumwang%40ebay.com%7Cc5216cd229664f939b6508db2e0855ed%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C638154385567464296%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=79Et30L9u4w4%2F%2B%2FTvPTpXEobOuvTV9XyVmapKC2qwoY%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > Binary artifacts are staged in Nexus here: > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Fgroups%2Fstaging%2Forg%2Fapache%2Fparquet%2F&data=05%7C01%7Cyumwang%40ebay.com%7Cc5216cd229664f939b6508db2e0855ed%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C638154385567464296%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Z%2FhRa8zc5ZHhs15Epx7X%2BIUwQJI4MoyPMOgAIJemvHU%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > This release includes important changes listed: > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fparquet-mr%2Fblob%2Fparquet-1.12.4%2FCHANGES.md&data=05%7C01%7Cyumwang%40ebay.com%7Cc5216cd229664f939b6508db2e0855ed%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C638154385567464296%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=SXURCILyTz6SYb3iNPEnedkgjMk%2BA%2FLYHyS4TvT4bbM%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please download, verify, and test. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please vote in the next 72 hours. > > > > > > > > > > > > > > > > > > > > > > > > > > > > [ ] +1 Release this as Apache Parquet 1.12.4 > > > > > > > > > > > > > > [ ] +0 > > > > > > > > > > > > > > [ ] -1 Do not release this because... > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > Gang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > Xinli Shang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Xinli Shang > > > > > >
