wgtmac commented on code in PR #1048:
URL: https://github.com/apache/parquet-mr/pull/1048#discussion_r1161378185


##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1127,7 +1127,7 @@ public void appendColumnChunk(ColumnDescriptor 
descriptor, SeekableInputStream f
     long length = chunk.getTotalSize();
     long newChunkStart = out.getPos();
 
-    if (newChunkStart != start) {
+    if (offsetIndex != null && newChunkStart != start) {

Review Comment:
   Good catch! Could you please add a test case to make sure this is well 
covered now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to