[ 
https://issues.apache.org/jira/browse/PARQUET-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711164#comment-17711164
 ] 

ASF GitHub Bot commented on PARQUET-2081:
-----------------------------------------

wgtmac commented on code in PR #1048:
URL: https://github.com/apache/parquet-mr/pull/1048#discussion_r1163478129


##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1127,7 +1127,7 @@ public void appendColumnChunk(ColumnDescriptor 
descriptor, SeekableInputStream f
     long length = chunk.getTotalSize();
     long newChunkStart = out.getPos();
 
-    if (newChunkStart != start) {
+    if (offsetIndex != null && newChunkStart != start) {

Review Comment:
   Thank you for adding test!
   
   BTW, PARQUET-2081 is a fixed issue for a new feature. Would you mind opening 
a new JIRA for this bug fix?





> Encryption translation tool - Parquet-hadoop
> --------------------------------------------
>
>                 Key: PARQUET-2081
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2081
>             Project: Parquet
>          Issue Type: Task
>          Components: parquet-mr
>            Reporter: Xinli Shang
>            Priority: Major
>             Fix For: 1.12.3
>
>
> This is the implement the core part of the Encryption translation tool in 
> parquet-hadoop. After this, we will have another Jira/PR for parquet-cli to 
> integrate with key tools for encryption properties.. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to