[
https://issues.apache.org/jira/browse/PARQUET-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714105#comment-17714105
]
ASF GitHub Bot commented on PARQUET-2290:
-----------------------------------------
Fokko commented on code in PR #1076:
URL: https://github.com/apache/parquet-mr/pull/1076#discussion_r1171248911
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java:
##########
@@ -1,185 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.parquet.thrift.projection.deprecated;
-
-import org.apache.hadoop.fs.GlobPattern;
-
-import com.google.re2j.Pattern;
-import com.google.re2j.PatternSyntaxException;
Review Comment:
This caused issues:
```
[ERROR]
/Users/fokkodriesprong/Desktop/parquet-mr/parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java:[55,49]
incompatible types: java.util.regex.Pattern cannot be converted to
com.google.re2j.Pattern
```
Different libraries are used in Hadoop 2 and 3. I think it makes sense to
remove this class since it is already marked deprecated for a very long time.
> Add CI for Hadoop 2
> -------------------
>
> Key: PARQUET-2290
> URL: https://issues.apache.org/jira/browse/PARQUET-2290
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Affects Versions: 1.13.0
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
