shangxinli commented on code in PR #1112:
URL: https://github.com/apache/parquet-mr/pull/1112#discussion_r1245231331


##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnReadStoreImpl.java:
##########
@@ -75,6 +75,9 @@ public ColumnReadStoreImpl(PageReadStore pageReadStore,
   public ColumnReader getColumnReader(ColumnDescriptor path) {
     PrimitiveConverter converter = getPrimitiveConverter(path);
     PageReader pageReader = pageReadStore.getPageReader(path);
+    if (pageReader.isNullMaskedColumn()) {

Review Comment:
   This change might not needed 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to