[
https://issues.apache.org/jira/browse/PARQUET-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751249#comment-17751249
]
ASF GitHub Bot commented on PARQUET-2332:
-----------------------------------------
sekikn opened a new pull request, #1130:
URL: https://github.com/apache/parquet-mr/pull/1130
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2332
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This PR adds no test, but it enables the following tests by adding `@Test`
annotation:
*
o.a.parquet.cli.commands.ToAvroCommandTest#testToAvroCommandWithGzipCompression
*
o.a.parquet.column.values.factory.DefaultValuesWriterFactoryTest#testFloat_V1_WithByteStreamSplitAndDictionary
*
o.a.parquet.column.values.factory.DefaultValuesWriterFactoryTest#testColumnWiseDictionaryWithFalseDefault
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
> Fix unexpectedly disabled tests to be executed
> ----------------------------------------------
>
> Key: PARQUET-2332
> URL: https://issues.apache.org/jira/browse/PARQUET-2332
> Project: Parquet
> Issue Type: Bug
> Components: parquet-testing
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Minor
>
> I found the following unit tests are (probably unexpectedly) disabled due to
> the lack of the {{@Test}} annotation.
> *
> o.a.parquet.cli.commands.ToAvroCommandTest#testToAvroCommandWithGzipCompression
> *
> o.a.parquet.column.values.factory.DefaultValuesWriterFactoryTest#testFloat_V1_WithByteStreamSplitAndDictionary
> *
> o.a.parquet.column.values.factory.DefaultValuesWriterFactoryTest#testColumnWiseDictionaryWithFalseDefault
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
