wgtmac commented on code in PR #1135:
URL: https://github.com/apache/parquet-mr/pull/1135#discussion_r1305146762
##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriteStoreBase.java:
##########
@@ -231,7 +231,9 @@ private void sizeCheck() {
long usedMem = writer.getCurrentPageBufferedSize();
long rows = rowCount - writer.getRowsWrittenSoFar();
long remainingMem = props.getPageSizeThreshold() - usedMem;
- if (remainingMem <= thresholdTolerance || rows >= pageRowCountLimit) {
+ if (remainingMem <= thresholdTolerance ||
+ rows >= pageRowCountLimit ||
+ writer.getValueCount() >= Integer.MAX_VALUE / 2) {
Review Comment:
Do you think it worths being added to the configuration properties for more
flexibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
