pitrou commented on code in PR #197:
URL: https://github.com/apache/parquet-format/pull/197#discussion_r1319445217
##########
src/main/thrift/parquet.thrift:
##########
@@ -977,6 +1038,25 @@ struct ColumnIndex {
/** A list containing the number of null values for each page **/
5: optional list<i64> null_counts
+
+ /**
+ * Contains repetition level histograms for more details) for each page
+ * concatenated together. The repetition_level_histogram field on
+ * SizeStatistics contains more details.
+ *
+ * When present the length should always be (number of pages *
+ * (max_repetition_level + 1)) elements in size.
+ *
+ * Element 0 is the first element of the histogram for the first page.
+ * Element (max_repetition_level + 1) is the first element of the histogram
+ * for the second page.
Review Comment:
Well, I guess I'm confused by the terminology as well. Perhaps we can drop
"row-major" and "column-major" entirely when discussing this? :-)
Personally, what I mean is that the levels of a given page should be
contiguous in memory. I suppose that can be called "page-major" but I might be
mistaken.
(if it was a 2D array or list, you would index first by page and then by
level)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
