gszadovszky commented on code in PR #216:
URL: https://github.com/apache/parquet-format/pull/216#discussion_r1335662614
##########
src/main/thrift/parquet.thrift:
##########
@@ -216,7 +216,12 @@ struct Statistics {
/** count of distinct values occurring */
4: optional i64 distinct_count;
/**
- * Min and max values for the column, determined by its ColumnOrder.
+ * lower and upper bound values for the column, determined by its
ColumnOrder.
Review Comment:
I am fine going in separately but it needs to be released together. I think,
the additional flag would complete fixing this situation. If an implementation
uses min/max values as existing values and realize this spec change we would
still give something to them to continue their approach. I agree if the flag is
not there we cannot assume the min/max values are actual values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
