findepi commented on code in PR #216:
URL: https://github.com/apache/parquet-format/pull/216#discussion_r1333952085
##########
src/main/thrift/parquet.thrift:
##########
@@ -216,7 +216,12 @@ struct Statistics {
/** count of distinct values occurring */
4: optional i64 distinct_count;
/**
- * Min and max values for the column, determined by its ColumnOrder.
+ * lower and upper bound values for the column, determined by its
ColumnOrder.
Review Comment:
@mapleFU very good point, we should not allow truncation to produce a value
that is invalid for given logical type
i think this is what @raunaqmorarka meant with `Such more compact values
must still be valid values within the column's logical type.` in the code
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
