letian-jiang opened a new pull request, #217:
URL: https://github.com/apache/parquet-format/pull/217

   Propose a draft PR since I'm requesting a JIRA account :-)
   
   > BOOLEAN: [Bit Packed](#BITPACKED), LSB first
   
   The bit-packed boolean has only one bit per value. Put `LSB first` here is 
confusing to me.
   
   > Dictionary page format: the entries in the dictionary - in dictionary 
order - using the [plain](#PLAIN) encoding.
   
   The dictionary entries are not sorted (or at least not always sorted).
   
   > There is no padding between values (except for the last byte) which is 
padded with 0s.
   
   Minor change.
   
   Please correct me if I get anything wrong.
   
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet 
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references 
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In 
addition, my commits follow the guidelines from "[How to write a good git 
commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain Javadoc that 
explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to