benibus commented on code in PR #1142:
URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1355712865
##########
parquet-column/src/main/java/org/apache/parquet/column/statistics/Statistics.java:
##########
@@ -139,6 +140,43 @@ public Statistics<?> build() {
}
}
+ // Builder for FLOAT16 type to handle special cases of min/max values like
NaN, -0.0, and 0.0
+ private static class Float16Builder extends Builder {
+ public Float16Builder(PrimitiveType type) {
+ super(type);
+ assert type.getPrimitiveTypeName() == PrimitiveTypeName.BINARY;
+ }
+
+ @Override
+ public Statistics<?> build() {
Review Comment:
Sorry, missed this comment somehow. Yes, this looks correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
