zhangjiashen commented on code in PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1359657237
########## parquet-column/src/test/java/org/apache/parquet/schema/TestTypeBuildersWithLogicalTypes.java: ########## @@ -205,10 +206,20 @@ public void testBinaryAnnotations() { } } + @Test + public void testFloat16Annotations() { + LogicalTypeAnnotation[] types = new LogicalTypeAnnotation[] {float16Type()}; + for (final LogicalTypeAnnotation logicalType : types) { Review Comment: delete necessary loop, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org