[
https://issues.apache.org/jira/browse/PARQUET-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774287#comment-17774287
]
ASF GitHub Bot commented on PARQUET-2357:
-----------------------------------------
wgtmac commented on PR #1160:
URL: https://github.com/apache/parquet-mr/pull/1160#issuecomment-1758766554
> Hi, @Fokko
>
> There is a test case failure, same one in another pull request(#1164). I
think it may pass if re-run. However, I don't have the permission to trigger
the run. I tried pushing again, but it didn't trigger a re-run. Could you
please take a look? Thank you very much.
>
> ```java
> 2023-10-02T11:22:48.6797210Z [INFO] Results:
> 2023-10-02T11:22:48.6894266Z [INFO]
> 2023-10-02T11:22:48.6895143Z [ERROR] Failures:
> 2023-10-02T11:22:48.6895878Z [ERROR]
TestParquetWriter.testParquetFileWithBloomFilterWithFpp:342
> 2023-10-02T11:22:48.6896575Z [INFO]
> 2023-10-02T11:22:48.6897791Z [ERROR] Tests run: 404, Failures: 1, Errors:
0, Skipped: 1
> ```
This test case unfortunately employs a random number for generating bloom
filter.
> Modest refactor of CapacityByteArrayOutputStream
> ------------------------------------------------
>
> Key: PARQUET-2357
> URL: https://issues.apache.org/jira/browse/PARQUET-2357
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Reporter: Feng Jiajie
> Priority: Minor
> Fix For: 1.14.0
>
>
> Optimization for the CapacityByteArrayOutputStream class:
> # The functionality of {{currentSlabIndex}} is the same as
> {{{}currentSlab.position(){}}}, so there is no need to maintain the
> {{currentSlabIndex}} variable.
> # When writing an array of length equal to the remaining capacity of the
> buffer, there is no need to expand to a new buffer.
> # If the {{addSlab}} operation has already implemented safeguards using
> {{Math.addExact}} to prevent overflow of {{bytesAllocated}} and
> {{{}bytesUsed{}}}, it is unnecessary to perform additional checks during the
> {{write}} operation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
