fengjiajie commented on PR #1165: URL: https://github.com/apache/parquet-mr/pull/1165#issuecomment-1758841809
@wgtmac Thank you for your review. The reason why write() no longer checks for overflow is because addSlab() ensures that bytesAllocated will not overflow. In the subsequent write() function, it is guaranteed that **bytesAllocated >= bytesUsed**, and thus bytesUsed will not overflow. But I agree that it would be advantageous to add the check here as well, I have changed the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
