ConeyLiu commented on code in PR #1141:
URL: https://github.com/apache/parquet-mr/pull/1141#discussion_r1358406653
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java:
##########
@@ -154,6 +171,10 @@ private static <T> RecordMaterializer<T>
newCompatMaterializer(
}
private GenericData getDataModel(Configuration conf, Schema schema) {
+ return getDataModel(new HadoopParquetConfiguration(conf), schema);
+ }
+
+ private GenericData getDataModel(ParquetConfiguration conf, Schema schema) {
Review Comment:
Same here, we could update the existing private method directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
