amousavigourabi commented on code in PR #1141:
URL: https://github.com/apache/parquet-mr/pull/1141#discussion_r1358428311
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/api/ReadSupport.java:
##########
@@ -75,14 +76,32 @@ public ReadContext init(
throw new UnsupportedOperationException("Override init(InitContext)");
}
+ /**
+ * called in {@link
org.apache.hadoop.mapreduce.InputFormat#getSplits(org.apache.hadoop.mapreduce.JobContext)}
in the front end
+ *
+ * @param configuration the configuration
+ * @param keyValueMetaData the app specific metadata from the file
+ * @param fileSchema the schema of the file
+ * @return the readContext that defines how to read the file
+ *
+ * @deprecated override {@link ReadSupport#init(InitContext)} instead
+ */
+ @Deprecated
Review Comment:
This PR is focussed on transitioning from `Configuration` to the
`ParquetConfiguration` interface. This included some calls to deprecated
methods which I could not very quickly transition away from. I would consider
this out-of-scope for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
