fengjiajie opened a new pull request, #1170: URL: https://github.com/apache/parquet-mr/pull/1170
Reduce failure rate of unit test testParquetFileWithBloomFilterWithFpp Change-Id: Ic230f197b0996333a082bb05bd201963d05d862e ``` [INFO] Results: [INFO] Error: Failures: Error: TestParquetWriter.testParquetFileWithBloomFilterWithFpp:342 [INFO] ``` Multiple different PR triggered this failure: 1. https://github.com/apache/parquet-mr/pull/1062 2. https://github.com/apache/parquet-mr/actions/runs/5420924489/job/14680382407 3. https://github.com/apache/parquet-mr/actions/runs/6336014897 4. https://github.com/apache/parquet-mr/actions/runs/6381223319 5. https://github.com/apache/parquet-mr/actions/runs/6394826826/job/17357106390 I found two issues that may cause the failures to occur easily: 1. This may be a bug. The 'distinctStrings' is used to generate test files, but it is cleared after generating the files. It is used for probability testing, so in the next round of generating 'fpp' files, it uses the data from the previous round of testing, and the length of the filled strings (length 10 for test not in bloomfilter) is also different from the initial one (strings length 12 for build bloomfilter). 2. The number of test iterations is insufficient, resulting in an unstable probability. Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR" - https://issues.apache.org/jira/browse/PARQUET-2361 - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
