[ https://issues.apache.org/jira/browse/PARQUET-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775505#comment-17775505 ]
ASF GitHub Bot commented on PARQUET-2355: ----------------------------------------- Fokko commented on PR #1158: URL: https://github.com/apache/parquet-mr/pull/1158#issuecomment-1763509863 @mystic-lama That's a possibility. I've sent out an email on the dev list with some more context: https://lists.apache.org/thread/bk74c7bk1wr63y5rw6tjwkxvdjjfb8kl The downside of keeping this is that we have to release with an old version of Thrift, which has challenges (you have to compile it locally for OSX). I've created a PR here to see [what's](https://github.com/apache/parquet-mr/pull/1138/) changed. Also, bumping elephantbird is not a possibility, see #1156 > Remove parquet-thrift > --------------------- > > Key: PARQUET-2355 > URL: https://issues.apache.org/jira/browse/PARQUET-2355 > Project: Parquet > Issue Type: Improvement > Reporter: Fokko Driesprong > Assignee: Fokko Driesprong > Priority: Major > > I was in the process of updating to [the latest version of > Thrift|https://github.com/apache/parquet-mr/pull/1138] (from 0.16.0 to > 0.19.0). Mostly because it contains CVEs and makes the release process easier > because you don't have to install Thrift from source (it is just available on > homebrew etc). > > While working on this, I ran into an issue with Elephantbird, which is using > a very old version of Thrift (0.7.0). Trying to bump this I noticed that a > lot of classes that we use in the tests > [have|https://github.com/apache/parquet-mr/pull/1156] [ been made > private|https://github.com/apache/parquet-mr/pull/1156]. Therefore it is hard > to test if we break anything. > > It looks like parquet-thrift [is not used by anyone > anymore|https://mvnrepository.com/artifact/org.apache.parquet/parquet-thrift]. > I would suggest removing this from the repository unless anyone objects. -- This message was sent by Atlassian Jira (v8.20.10#820010)