gszadovszky commented on code in PR #1173:
URL: https://github.com/apache/parquet-mr/pull/1173#discussion_r1361845354


##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java:
##########
@@ -543,6 +546,11 @@ public static ColumnIndex build(
    *          the statistics to be added
    */
   public void add(Statistics<?> stats) {
+    if (stats.isEmpty()) {

Review Comment:
   I am not sure how column index writing worked for the "rewriter". This 
rewriting thing is newer than the column index. In the normal writing scenario 
`stats` cannot be empty since we are just creating these objects during the 
write path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to