[
https://issues.apache.org/jira/browse/PARQUET-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781414#comment-17781414
]
ASF GitHub Bot commented on PARQUET-2371:
-----------------------------------------
amousavigourabi opened a new pull request, #1181:
URL: https://github.com/apache/parquet-mr/pull/1181
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
No user facing changes, only resolves CI failure.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
---
Japicmp failed on newly introduced classes, during review this did not cause
a failure. This likely has something to do with the japicmp 0.18.1 update we
pushed since then (for this, see #1176). Includes bumping japicmp to 0.18.2.
The false positives were all under the banner of
`CLASS_GENERIC_TEMPLATE_CHANGED`. Similar problems seem to have been reported
before at siom79/japicmp#345.
> Resolve japicmp failure for CI
> ------------------------------
>
> Key: PARQUET-2371
> URL: https://issues.apache.org/jira/browse/PARQUET-2371
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Reporter: Atour Mousavi Gourabi
> Priority: Major
>
> Japicmp triggers on newly added methods, which have not been changed. This is
> likely a japicmp bug. Excludes should be added for the affected classes, as
> otherwise the CI job will not run anything after the japicmp goal. See the
> discussion at https://github.com/apache/parquet-mr/pull/1141.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
